gh-155499: Fix curses window.border() and window.box() with 0 - #155871
Merged
serhiy-storchaka merged 3 commits intoAug 21, 2026
Conversation
The integer 0 asks for the default character, but it was rejected when passed together with a string character. Choose the drawing function by what the arguments need: only a complexchar cannot be drawn as a byte character, and a string character is narrowed when one is needed. Document the defaults as 0 rather than as the ACS_* codes, which are not defined before initscr().
Documentation build overview
17 files changed ·
|
The regression is not in any release: wide characters in border() and box() are new in 3.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integer
0asks for the default character, but it was rejected when passed together with a string character.Now the drawing function is chosen by what the arguments need: only a
complexcharcannot be drawn as a byte character, and a string character is narrowed when one is needed.The defaults are also documented as
0rather than as theACS_*codes, which are not defined beforeinitscr().border()andbox()no longer accept0with astr#155499