I decided to remove this cast as it's unneeded.

I decided to remove this cast as it's unneeded.

Any idea as to why this cast was previously needed?

@serhiy-storchaka you committed this code in 32d96a2. Does it make sense to you to remove this cast?

It was copied from Python/getargs.c.

I would prefer to keep the explicit cast, since long long is an uncommon type and I prefer to avoid bad surprises on some platforms.

@vstinner I don't really see a problem here, because implicit conversion of integers of the same signedness is well defined and always lossless. If it's so important it can be rewritten as:

if ({paramname} == -1LL && PyErr_Occurred()) {{{{

In that case there are no casts at all.

Ok.

I don't really see a problem here, because implicit conversion of integers of the same signedness is well defined and always lossless

@vstinner @serhiy-storchaka So is this okay universally across the C-API or is it different in other areas? Of course it wouldn't be worth a PR on it's own since it's more of a conventional/styling decision, I just want to know in case I see a similar implicit integer conversion (signed -> signed or unsigned -> unsigned) without the cast in another PR or if the issue comes up again.

I have no idea. The C language remains partially a mystery to me.

@vstinner

I have no idea. The C language remains partially a mystery to me.

If the C language is partially a mystery even to you, what hope do the rest of us mere mortals have? ;)

I would prefer to keep the explicit cast.