gh-153634: Raise csv.Error, not ValueError, from csv.Sniffer for an inconsistent guessed dialect#153635
Closed
tonghuaroot wants to merge 3 commits into
Closed
gh-153634: Raise csv.Error, not ValueError, from csv.Sniffer for an inconsistent guessed dialect#153635tonghuaroot wants to merge 3 commits into
tonghuaroot wants to merge 3 commits into
Conversation
…r an inconsistent guessed dialect csv.Sniffer.sniff could return a dialect whose delimiter equaled its quote character. Using that dialect (directly, or via csv.Sniffer.has_header, which builds a reader from the sniffed dialect) leaked a raw ValueError from the _csv extension instead of the module's own csv.Error. sniff now validates its guessed dialect before returning it and re-raises the _csv ValueError as csv.Error, so both sniff and has_header report the module exception type. The direct csv.reader and csv.writer paths and the Dialect._validate TypeError/ValueError behavior are unchanged.
Member
|
Thank you for the patch, but I think that the fix should be made earlier: the delimiter should not be guessed to be the detected quote character in the first place. Note also that on the main branch the sniffer was rewritten (gh-83273) and it already raises |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csv.Sniffer.sniff()could return a dialect whose delimiter equals its quotechar, so using it (directly or viahas_header) leaked a rawValueErrorfrom_csvinstead ofcsv.Error. Validate the guessed dialect before returning it and re-raise theValueErrorascsv.Error; the throwaway reader validates the full_csvinvariant set, so future_guess_*changes cannot silently return another invalid dialect.