Repository navigation
gh-140456: Document that FrameSummary.line is a single line - #153469
Closed
harjothkhara wants to merge 6 commits into
Closed
harjothkhara wants to merge 6 commits into
harjothkhara wants to merge 6 commits into
Conversation
Documentation build overview
455 files changed ·
|
harjothkhara
force-pushed
the
codex/gh-140456-traceback-docs
branch
2 times, most recently
from
July 10, 2026 01:14
6202ef6 to
5bc4855
Compare
harjothkhara
force-pushed
the
codex/gh-140456-traceback-docs
branch
from
July 10, 2026 01:22
5bc4855 to
67bab37
Compare
Column position information alone is not enough: end_lineno defaults to lineno, so a frame with colno/end_colno but no end_lineno still shows only its first physical line. Say so, and test it.
harjothkhara
marked this pull request as ready for review
July 10, 2026 02:19
Contributor
Author
|
Docs only change for #140456, could someone take a look? |
Drops the multi-line formatting docs, tests and NEWS entry, as suggested on the issue. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
harjothkhara
changed the title
Contributor
Author
|
@serhiy-storchaka following your comment on the issue closely, I trimmed this to only say that |
Member
|
I feel that this explanation makes the entire paragraph unnecessarily verbose, and its relevance to the original issue is rather limited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrameSummary.lineonly ever holds one line of source, but that stopped being obvious onceend_linenowas added. This says so in the docs and in theFrameSummarydocstring.As serhiy-storchaka noted on the issue, the behavior for a multi-line
linewas never specified, so this doesn't describe it. The change is two sentences, one in the docs and one in the docstring.Lib/traceback.pyis docstring-only, so there is no behavior change.Checked with sphinx-lint and a scoped docs build (no warnings from
traceback.rst), andtest_tracebackpasses. No NEWS entry, since it is a docs and docstring change.I used AI assistance for this and have reviewed the change.
traceback.format_list()breaking behavior change. #140456