Skip to content

bpo-32793: Fix a duplicate debug message in smtplib#15341

Merged
miss-islington merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-32793-smtplib-duplicated-debug
Aug 20, 2019
Merged

bpo-32793: Fix a duplicate debug message in smtplib#15341
miss-islington merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-32793-smtplib-duplicated-debug

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

_get_socket() already prints a debug message for the host and port.

https://bugs.python.org/issue32793

Automerge-Triggered-By: @maxking

_get_socket() already prints a debug message for the host and port.
@maxking

maxking commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

Mostly LGTM.

Thanks!

@miss-islington
miss-islington merged commit 46a7564 into python:master Aug 20, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @ZackerySpytz, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 46a7564578f208df1e0c54fc0520d3b7ca32c981 3.7

@miss-islington miss-islington self-assigned this Aug 20, 2019
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
_get_socket() already prints a debug message for the host and port.



https://bugs.python.org/issue32793



Automerge-Triggered-By: @maxking
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
_get_socket() already prints a debug message for the host and port.



https://bugs.python.org/issue32793



Automerge-Triggered-By: @maxking
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
_get_socket() already prints a debug message for the host and port.



https://bugs.python.org/issue32793



Automerge-Triggered-By: @maxking
corona10 pushed a commit to corona10/cpython that referenced this pull request Oct 13, 2020
…5341)

_get_socket() already prints a debug message for the host and port.

https://bugs.python.org/issue32793

Automerge-Triggered-By: @maxking
(cherry picked from commit 46a7564)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-22683 is a backport of this pull request to the 3.8 branch.

corona10 added a commit that referenced this pull request Oct 13, 2020
…H-22683)

_get_socket() already prints a debug message for the host and port.

https://bugs.python.org/issue32793

Automerge-Triggered-By: @maxking
(cherry picked from commit 46a7564)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants