gh-152433: Windows: _winapi.c implement GetVersion() UWP alternative#152694
Merged
Conversation
…P alternative
chris-eibl
approved these changes
Jul 19, 2026
chris-eibl
left a comment
chris-eibl
left a comment
Member
There was a problem hiding this comment.
LGTM.
I hardly think this will have any user on XBOX, though, and even on Desktop the main usage was for subprocess to check whether we're on Win9x
Lines 1030 to 1033 in 23bba4c
which has been ripped out a while ago. IOW, it is not used in the Python codebase itself anymore (but there might be users out there, even though starting with an underscore and GetVersion "lying" at you when running in compatibility / manifested mode).
Member
Well, other stuff that's typically directly linked to the version number also gets changed, so if you are trying to detect whether some API behaves a certain way by checking the version number, then you'll want the reported version number to match the compatibility shims that you're getting when you call the API. It's only a lie if your goal is to print the current version to a human, which is why the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows:
_winapi.cimplementGetVersion()UWP alternative.