gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_bound_or_default#152684
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reserved name (e.g.
__classdict__) is used as a type parameter,symtable_visit_type_param_bound_or_default()callsPyUnicode_FromFormat()to build the
SyntaxErrormessage. If the allocation fails and returnsNULL,the subsequent
PyErr_SetObject(PyExc_SyntaxError, NULL)andPy_DECREF(NULL)calls dereference the null pointer, causing a segfault.
Fix by returning
0immediately whenPyUnicode_FromFormat()returnsNULL,which propagates the
MemoryErroralready set byPyUnicode_FromFormat().The bug was introduced in gh-128632 (commit 891c61c).
Found by static analyzer Svace (ISP RAS).
Misc/NEWS.d/test_disallowed_type_param_names_oom)