bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() by corona10 · Pull Request #15266 · python/cpython

corona10 · 2019-08-14T05:11:01Z

https://bugs.python.org/issue37798

rhettinger · 2019-08-15T04:58:29Z

The usual way we do this is to define the function in pure python. Then, somewhere below that definition, try to import the C accelerator function in its place. For examples, see line 458 in Lib/collections/__init__.py for _count_elements() or line 579 in Lib/heapq.py

corona10 · 2019-08-15T06:12:03Z

@rhettinger

Thanks a lot.
I 've updated the PR as you suggested.
I both test when using pure python version and C version.
And it looks same on both versions.
Please take a look.

bedevere-bot · 2019-08-15T06:46:35Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10 · 2019-08-15T08:16:34Z

I have made the requested changes; please review again

bedevere-bot · 2019-08-15T08:16:37Z

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

corona10 · 2019-08-21T23:14:54Z

@rhettinger Can you please take a look?

bedevere-bot · 2019-08-22T03:41:46Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger · 2019-08-22T03:42:04Z

Thanks for doing this. I think we're getting close :-)

corona10 · 2019-08-22T09:46:12Z

Thanks for the review, I will take look at!

corona10 · 2019-08-23T14:25:57Z

@rhettinger I've updated the PR!

miss-islington · 2019-08-23T22:20:33Z

Thanks @corona10 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-08-23T22:20:46Z

GH-15441 is a backport of this pull request to the 3.8 branch.

…GH-15266) (cherry picked from commit 0a18ee4) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

rhettinger · 2019-08-23T22:23:33Z

Nice work. Thanks for doing this :-)

…) (GH-15441) (cherry picked from commit 0a18ee4) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

…GH-15266)

corona10 requested a review from a team as a code owner August 14, 2019 05:11

the-knights-who-say-ni added the CLA signed label Aug 14, 2019

bedevere-bot added the awaiting review label Aug 14, 2019

corona10 force-pushed the bpo-37798 branch 3 times, most recently from 8f96826 to fa18af8 Compare August 14, 2019 05:39

tirkarthi reviewed Aug 14, 2019

View reviewed changes

Comment thread Lib/statistics.py Outdated

corona10 changed the title ~~bpo-37998: Add C fastpath for statistics.NormalDist.inv_cdf()~~ bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() Aug 14, 2019

corona10 force-pushed the bpo-37798 branch 4 times, most recently from 5a77376 to ba81a90 Compare August 14, 2019 08:51

rhettinger self-assigned this Aug 15, 2019

corona10 force-pushed the bpo-37798 branch from ba81a90 to 9663297 Compare August 15, 2019 05:58

rhettinger reviewed Aug 15, 2019

View reviewed changes

Comment thread Lib/statistics.py Outdated

corona10 force-pushed the bpo-37798 branch from 9663297 to ccec88f Compare August 15, 2019 06:41

rhettinger requested changes Aug 15, 2019

View reviewed changes

Comment thread Modules/_statisticsmodule.c Outdated

bedevere-bot removed the awaiting review label Aug 15, 2019

bedevere-bot added the awaiting changes label Aug 15, 2019

corona10 force-pushed the bpo-37798 branch from ccec88f to ba6bc56 Compare August 15, 2019 07:52

bedevere-bot added awaiting change review and removed awaiting changes labels Aug 15, 2019

rhettinger requested changes Aug 22, 2019

View reviewed changes

Comment thread Lib/statistics.py Outdated

Comment thread Modules/_statisticsmodule.c Outdated

Comment thread Modules/_statisticsmodule.c Outdated

Comment thread Modules/_statisticsmodule.c Outdated

bedevere-bot removed the awaiting change review label Aug 22, 2019

bedevere-bot added the awaiting changes label Aug 22, 2019

corona10 force-pushed the bpo-37798 branch from ba6bc56 to a921c83 Compare August 23, 2019 12:52

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf()

c004470

corona10 force-pushed the bpo-37798 branch from a921c83 to c004470 Compare August 23, 2019 12:57

rhettinger approved these changes Aug 23, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Aug 23, 2019

rhettinger added the needs backport to 3.8 label Aug 23, 2019

rhettinger merged commit 0a18ee4 into python:master Aug 23, 2019

bedevere-bot removed the awaiting merge label Aug 23, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2019

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (python…

8fa946f

…GH-15266) (cherry picked from commit 0a18ee4) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot removed the needs backport to 3.8 label Aug 23, 2019

rhettinger pushed a commit that referenced this pull request Aug 23, 2019

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (GH-15266…

5779c53

…) (GH-15441) (cherry picked from commit 0a18ee4) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

corona10 deleted the bpo-37798 branch August 24, 2019 06:03

corona10 mentioned this pull request Aug 27, 2019

bpo-37798: Fix _statistics module doc #15546

Merged

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (python…

ea32c7a

…GH-15266)

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (python…

ef19966

…GH-15266)

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (python…

0a86fc7

…GH-15266)

Uh oh!

Conversation

corona10 commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rhettinger commented Aug 15, 2019

Uh oh!

corona10 commented Aug 15, 2019

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Aug 15, 2019

Uh oh!

corona10 commented Aug 15, 2019

Uh oh!

bedevere-bot commented Aug 15, 2019

Uh oh!

corona10 commented Aug 21, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Aug 22, 2019

Uh oh!

rhettinger commented Aug 22, 2019

Uh oh!

corona10 commented Aug 22, 2019

Uh oh!

corona10 commented Aug 23, 2019

Uh oh!

miss-islington commented Aug 23, 2019

Uh oh!

bedevere-bot commented Aug 23, 2019

Uh oh!

rhettinger commented Aug 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

corona10 commented Aug 14, 2019 •

edited

Loading