Skip to content

[3.8] bpo-37354: Make Powershell Activate.ps1 script static to allow for signing (GH-14967)#15233

Merged
zooba merged 1 commit into
python:3.8from
miss-islington:backport-732775d-3.8
Aug 12, 2019
Merged

[3.8] bpo-37354: Make Powershell Activate.ps1 script static to allow for signing (GH-14967)#15233
zooba merged 1 commit into
python:3.8from
miss-islington:backport-732775d-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 12, 2019

Copy link
Copy Markdown
Contributor
  • Remove use of replacement text in the script
  • Make use of the pyvenv.cfg file for prompt value.
  • Add parameters to allow more flexibility
  • Make use of the current path, and assumptions about where env puts things, to compensate
  • Make the script a bit more 'idiomatic' Powershell
  • Add script documentation (Get-Help ..venv\Scripts\Activate.ps1 shows PS help page now
    (cherry picked from commit 732775d)

Co-authored-by: Derek Keeler d3r3kk@users.noreply.github.com

https://bugs.python.org/issue37354

…gning (pythonGH-14967)

- Remove use of replacement text in the script
- Make use of the pyvenv.cfg file for prompt value.
- Add parameters to allow more flexibility
- Make use of the current path, and assumptions about where env puts things, to compensate
- Make the script a bit more 'idiomatic' Powershell
- Add script documentation (Get-Help .\.venv\Scripts\Activate.ps1 shows PS help page now
(cherry picked from commit 732775d)

Co-authored-by: Derek Keeler <d3r3kk@users.noreply.github.com>
@zooba

zooba commented Aug 12, 2019

Copy link
Copy Markdown
Member

Let's hold off merging this until we've done a little more manual testing on the master build.

It should be merged before the next beta is released.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@d3r3kk and @zooba: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@d3r3kk and @zooba: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@d3r3kk and @zooba: Status check is done, and it's a success ✅ .

@zooba
zooba merged commit 0c64b57 into python:3.8 Aug 12, 2019
@miss-islington
miss-islington deleted the backport-732775d-3.8 branch August 12, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants