Skip to content

gh-152235: Defer GC tracking in more set operations#152273

Merged
corona10 merged 1 commit into
python:mainfrom
corona10:gh-152235-methods
Jun 26, 2026
Merged

gh-152235: Defer GC tracking in more set operations#152273
corona10 merged 1 commit into
python:mainfrom
corona10:gh-152235-methods

Conversation

@corona10

@corona10 corona10 commented Jun 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from rhettinger as a code owner June 26, 2026 13:05
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2026
Open
@corona10 corona10 requested review from methane and vstinner June 26, 2026 13:05
@corona10 corona10 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes topic-free-threading labels Jun 26, 2026
vstinner
vstinner approved these changes Jun 26, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This change itself is correct, but there are other functions which are still unsafe like set_or() which tracks the frozenset immediately.

@corona10 corona10 merged commit a87d24a into python:main Jun 26, 2026
68 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152278 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152279 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152280 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2026
@corona10 corona10 deleted the gh-152235-methods branch June 26, 2026 13:37
corona10 added a commit that referenced this pull request Jun 26, 2026
@miss-islington @corona10
[3.15] gh-152235: Defer GC tracking in more set operations (gh-152273) (
7ed6737 
gh-152278)

gh-152235: Defer GC tracking in more set operations (gh-152273)
(cherry picked from commit a87d24a)

Co-authored-by: Donghee Na <donghee.na@python.org>
corona10 added a commit that referenced this pull request Jun 26, 2026
@miss-islington @corona10
[3.14] gh-152235: Defer GC tracking in more set operations (gh-152273) (
e1dc5f5 
gh-152279)

gh-152235: Defer GC tracking in more set operations (gh-152273)
(cherry picked from commit a87d24a)

Co-authored-by: Donghee Na <donghee.na@python.org>
@vstinner vstinner mentioned this pull request Jun 26, 2026
Open
corona10 added a commit that referenced this pull request Jun 26, 2026
@miss-islington @corona10
[3.13] gh-152235: Defer GC tracking in more set operations (gh-152273) (
80dddd2 
gh-152280)

gh-152235: Defer GC tracking in more set operations (gh-152273)
(cherry picked from commit a87d24a)

Co-authored-by: Donghee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@methane methane Awaiting requested review from methane

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10 @vstinner