Skip to content

gh-151929: Add pythoninfo-build command to Platforms/emscripten#152210

Merged
vstinner merged 6 commits into
python:mainfrom
vstinner:emscripten_pythoninfo_host
Jun 25, 2026
Merged

gh-151929: Add pythoninfo-build command to Platforms/emscripten#152210
vstinner merged 6 commits into
python:mainfrom
vstinner:emscripten_pythoninfo_host

Conversation

@vstinner

@vstinner vstinner commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Add also "pythoninfo-host" command.

@vstinner
pythongh-151929: Add pythoninfo-build command to Platforms/emscripten
12befad 
Replace also "run --test" with "pythoninfo-host" command.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2026
Open
@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

pythoninfo-build displays the 3 new system. keys which can help debugging issues: detect on which machine the job was ran and detect when the machine has been rebooted.

Examples:

CC.version: gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0
...
sys.version: 3.16.0a0 (remotes/pull/152210/merge-dirty:ee07825, Jun 25 2026, 14:57:29) [GCC 13.3.0]
...
system.boot_id: 02b5e273-98cf-4f41-87ce-cbabd3479518
system.machine_id: b9d4e40b90bc4dcb974f6d60e5fb946e
system.uptime: 0:03:15

@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 25, 2026
@vstinner vstinner marked this pull request as ready for review June 25, 2026 15:16
@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@hoodmane: Would you mind to review this change?

My plan is to backport this change to 3.13, 3.14 and 3.15 branches, and then update the buildbot configuration to call these new commands. And once buildbots are migrated, remove the legacy run --pythoninfo command (at least in the main branch).

@vstinner vstinner mentioned this pull request Jun 25, 2026
Merged
@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I wrote a similar change for WASI: #152136.

@hoodmane

hoodmane commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Can you explain the relationship to issue #151929? It's not obvious to me.

hoodmane
hoodmane approved these changes Jun 25, 2026
View reviewed changes

@hoodmane hoodmane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Can you explain the relationship to issue #151929? It's not obvious to me.

I reused the issue gh-151929 to add boot ID, machine ID and uptime to pythoninfo, to help me debugging a performance like the one on the WASI buildbot.

This PR is the Emscripten part of this work.

@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Display build info of the build Python:

system.boot_id: 74bf7c41-8422-48f2-910c-f8053609b525
system.machine_id: b9d4e40b90bc4dcb974f6d60e5fb946e
system.uptime: 0:02:07

Display build info of the host/Emscripten Python:

system.machine_id: b9d4e40b90bc4dcb974f6d60e5fb946e

Interesting, the machine ID of the host machine is inherited by the Emscripten filesystem.

@vstinner vstinner enabled auto-merge (squash) June 25, 2026 16:13
@vstinner vstinner merged commit 7676427 into python:main Jun 25, 2026
27 checks passed
@vstinner vstinner deleted the emscripten_pythoninfo_host branch June 25, 2026 16:32
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7676427cd875a4b7b3d1ad8521b0de151b9e1e63 3.13

@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152217 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 25, 2026
@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152218 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2026
@vstinner vstinner removed the needs backport to 3.13 bugs and security fixes label Jun 25, 2026
@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

My plan is to backport this change to 3.13, 3.14 and 3.15 branches, (...)

Oh I was wrong, Emscripten is not supported in Python 3.13: Platforms/emscripten/ doesn't exist in 3.13.

vstinner added a commit that referenced this pull request Jun 25, 2026
@miss-islington @vstinner
[3.15] gh-151929: Add pythoninfo-build command to Platforms/emscripten (
25c7b0c 
GH-152210) (#152217)

gh-151929: Add pythoninfo-build command to Platforms/emscripten (GH-152210)

* Add also "pythoninfo-host" command.
* Add pythoninfo to the "build" command.
(cherry picked from commit 7676427)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 25, 2026
@miss-islington @vstinner
[3.14] gh-151929: Add pythoninfo-build command to Platforms/emscripten (
8162f61 
GH-152210) (#152218)

gh-151929: Add pythoninfo-build command to Platforms/emscripten (GH-152210)

* Add also "pythoninfo-host" command.
* Add pythoninfo to the "build" command.
(cherry picked from commit 7676427)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I deployed a new buildbot configuration to run also pythoninfo-build: python/buildmaster-config#745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoodmane hoodmane hoodmane approved these changes
@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742 freakboy3742 is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee is a code owner

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @hoodmane