gh-144361: Fix NameError when type parameter default refers to a forward name#152208
Open
tangyuan0821 wants to merge 2 commits into
Open
gh-144361: Fix NameError when type parameter default refers to a forward name#152208tangyuan0821 wants to merge 2 commits into
tangyuan0821 wants to merge 2 commits into
Conversation
tangyuan0821
changed the title
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks, please add tests covering the new behavior.
| args = prepare(cls, args) | ||
| try: | ||
| args = prepare(cls, args) | ||
| except NameError: |
Member
There was a problem hiding this comment.
I don't understand this part, why do we have to add default here?
Contributor
Author
There was a problem hiding this comment.
The C implementation of TypeVar.typing_prepare_subst doesn't catch NameError
when the default is a forward ref — it just raises and returns NULL, so it never
gets a chance to add the default to args. I do both in the except block.
For TypeVarTuple/ParamSpec, their C code delegates to the Python prepare
functions which already handle this themselves, so the outer catch is redundant
for those but harmless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #144361: PEP 696 + PEP 749 — delayed evaluation of type parameter defaults.
Three call sites in Lib/typing.py eagerly evaluate default (Format.VALUE),
which fails when the default references a name defined later in the module.
Catch NameError and fall back to annotationlib.call_evaluate_function
with Format.FORWARDREF.