Skip to content

plistlib: fix TypeError when parsing partial ISO 8601 dates (gh-151221) #151285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
walsoup wants to merge 2 commits into from
+12 −3
Closed

plistlib: fix TypeError when parsing partial ISO 8601 dates (gh-151221) #151285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d08764
plistlib: fix TypeError when parsing partial ISO 8601 dates
walsoup Jun 10, 2026
9285789
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Lib/plistlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,17 @@ def _date_from_string(s, aware_datetime):
lst = []
for key in order:
val = gd[key]
if val is None:
break
lst.append(int(val))
if val is not None:
lst.append(int(val))
else:
# Fill missing components with defaults: month/day -> 1, hour/minute/second -> 0
if key in ('month', 'day'):
lst.append(1)
elif key in ('hour', 'minute', 'second'):
lst.append(0)
else:
# Year should never be missing due to regex
raise ValueError("Missing year in date string")
if aware_datetime:
return datetime.datetime(*lst, tzinfo=datetime.UTC)
return datetime.datetime(*lst)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-06-10-20-33-34.gh-issue-151221.gV-PqB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
plistlib._date_from_string() was raising a confusing TypeError for partial ISO 8601 dates (e.g., '2024-06Z') because it broke early on missing components. The fix fills missing components with sensible defaults: month/day → 1, hour/minute/second → 0.
Loading