Add yet one assertion in test_set_text_charset_cp949#151224
Merged
serhiy-storchaka merged 1 commit intoJun 10, 2026
Merged
Conversation
Check bytes(m), not only str(m).
serhiy-storchaka
added
tests
| self.assertEqual(m.get_payload(decode=True).decode('ks_c_5601-1987'), content) | ||
| self.assertEqual(bytes(m), textwrap.dedent("""\ | ||
| Content-Type: text/plain; charset="ks_c_5601-1987" | ||
| Content-Transfer-Encoding: 8bit |
Member
Author
There was a problem hiding this comment.
I am a bit surprised that Content-Transfer-Encoding is 8bit instead of base64, like above. This I why I add this test.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-151237 is a backport of this pull request to the 3.15 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
removed
needs backport to 3.13
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check bytes(m), not only str(m).