bpo-30217: add the operators ~ and | to the index#1502
Merged
Conversation
|
@marco-buttu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ncoghlan and @benjaminp to be potential reviewers. |
marco-buttu
commented
May 9, 2017
Contributor
Author
There was a problem hiding this comment.
Inversion or inverting?
Member
There was a problem hiding this comment.
I think this index entry is not needed. ~ is a bitwise operation. There are no separate index entries for bitwise conjunction and disjunction.
Contributor
Author
|
Thanks @serhiy-storchaka, I remove the last commit (that introduced the |
serhiy-storchaka
approved these changes
May 10, 2017
Member
|
@serhiy-storchaka maybe we could merge it. |
Member
|
Yes, thank you for the reminder. Do you mind to backport the change to other branches? |
Contributor
Author
This was referenced Jun 12, 2017
Mariatta
pushed a commit
that referenced
this pull request
Jun 12, 2017
Mariatta
pushed a commit
that referenced
this pull request
Jun 12, 2017
Mariatta
pushed a commit
that referenced
this pull request
Jun 12, 2017
Member
|
Thanks for the PRs @marco-buttu 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bpo-30217: Missing entry for the tilde (~) operator in the Index. Also the
|operator was not indexed.