bpo-36002: fail to find -llvm-profdata#14998
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
weibullguy
changed the title
weibullguy
changed the title
|
Is there a reason we shouldn't fix this problem by calling |
|
You obviously have me confused with a competent programmer. My understanding of the AC_PATH_TOOL macros and friends is that they use the AC_CANONICAL_XXX macros. But, they also include some additional magic when host/target prefixed applications aren't found to use non-prefixed applications that are found. It seems that behavior would need to be reproduced. That said, the reasons I chose this route were: 1). It was the simplest solution to the problem I could see and felt comfortable making (I'm a hack, not a hacker). |
|
Thanks @weibullguy for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
…pythonGH-14998) (cherry picked from commit 0519d49) Co-authored-by: Doyle Rowland <doyle.rowland@reliaqual.com>
|
GH-16104 is a backport of this pull request to the 3.8 branch. |
|
GH-16105 is a backport of this pull request to the 3.7 branch. |
…pythonGH-14998) (cherry picked from commit 0519d49) Co-authored-by: Doyle Rowland <doyle.rowland@reliaqual.com>
|
I'm accepting this on the basis that |
5 participants
The llvm-profdata is added using the AC_PATH_TARGET_TOOL in configure.ac. Per the autoconf documentation for the AC_PATH_TARGET_TOOL, "If the tool cannot be found with a prefix, and if the build and target types are equal, then it is also searched for without a prefix." However, only the AC_CANONICAL_HOST macro is called in the configure.ac script which means target will be set to '' while host and build are set to the values produced by config.guess. Thus, when configure attempts to find $target_alias-llvm-profdata, it will search for -llvm-profdata (note leading dash), which will not be found on probably any system.
However, the macro AC_PATH_TOOL will search for the un-prefixed tool (llvm-profdata in this case) if a prefixed version is not found on the path. This pull request replaces the AC_PATH_TARGET_TOOL macro with the AC_PATH_TOOL macro in configure.ac in two places (for llvm-profdata and llvm-ar).
With this change, Python built and tested satisfactorily using gcc v5.5.0 and clang v3.8.0, both with the --target switch set and without.
https://bugs.python.org/issue36002