Skip to content

bpo-35771: Increase the hover_delay in IDLE's test_tooltip #14926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZackerySpytz wants to merge 2 commits into from
Closed

bpo-35771: Increase the hover_delay in IDLE's test_tooltip #14926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bac32e
bpo-35771: Increase the hover_delay in IDLE's test_tooltip
ZackerySpytz Jul 24, 2019
c249a9f
Make the requested changes.
ZackerySpytz Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Lib/idlelib/idle_test/test_tooltip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,16 @@ def test_showtip_on_mouse_enter_no_delay(self):
self.assertGreater(len(tooltip.showtip.call_args_list), 0)

def test_showtip_on_mouse_enter_hover_delay(self):
tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=50)
# Fragile test -- see issue 35771.
tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=100)
self.addCleanup(tooltip.hidetip)
tooltip.showtip = add_call_counting(tooltip.showtip)
root_update()
self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
self.button.event_generate('<Enter>', x=0, y=0)
root_update()
self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
time.sleep(0.1)
time.sleep(0.15)
root_update()
self.assertTrue(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
self.assertGreater(len(tooltip.showtip.call_args_list), 0)
Expand All @@ -128,15 +129,15 @@ def test_hidetip_on_mouse_leave(self):
self.assertGreater(len(tooltip.showtip.call_args_list), 0)

def test_dont_show_on_mouse_leave_before_delay(self):
tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=50)
tooltip = Hovertip(self.button, 'ToolTip text', hover_delay=100)
self.addCleanup(tooltip.hidetip)
tooltip.showtip = add_call_counting(tooltip.showtip)
root_update()
self.button.event_generate('<Enter>', x=0, y=0)
root_update()
self.button.event_generate('<Leave>', x=0, y=0)
root_update()
time.sleep(0.1)
time.sleep(0.15)
root_update()
self.assertFalse(tooltip.tipwindow and tooltip.tipwindow.winfo_viewable())
self.assertEqual(tooltip.showtip.call_args_list, [])
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2019-08-03-05-27-39.bpo-35771.LfQWI-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Increase the ``hover_delay`` in IDLE's test_tooltip.