bpo-37627: Initialize IDLE Custom Run dialog with previous entries by nsiregar · Pull Request #14870 · python/cpython

nsiregar · 2019-07-20T16:35:33Z

Repeat the command line arguments most recently entered before so the user can edit them.

https://bugs.python.org/issue37627

terryjreedy · 2019-07-20T17:06:28Z

Please be very careful with bpo numbers when submitting. To fix, one must go the wrong issue and remove the misplaced link, then change the number in the title and 3 places in the comment. (This should be in the devguide.)

terryjreedy

The tracker issue and this PR are about two different subjects: the Run menu and persisting user command line entries. I will want these split, but can't now say what change to make.

So don't do anything immediately.

bedevere-bot · 2019-07-20T17:25:21Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger · 2019-07-20T20:41:27Z

Can we get this done before 3.8 goes final? The user testing indicated that both sub-issues were problematic. That said, I'm happy to have the feature at all. It was a nice improvment for developing command-line scripts using IDLE.

terryjreedy · 2019-07-21T00:44:55Z

I want to split the menu change, for which I have an alternative proposal, from the argument persistence, which I was going to merge by tomorrow. I did not realize that 'delete file' meant 'delete the whole file' as opposed to the changes to the file, so I have to patch this PR or write another. There does not seem to be a way in the UI to revert a deletion.

This reverts commit 01d7b17.

This reverts commit e347e5b.

nsiregar · 2019-07-21T07:58:15Z

Yeah, Siregar it is

miss-islington · 2019-07-21T15:37:31Z

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-07-21T15:37:31Z

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

…ythonGH-14870) Repeat the command line arguments most recently entered before so the user can edit them. (cherry picked from commit 35b87e6) Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

bedevere-bot · 2019-07-21T15:37:43Z

GH-14881 is a backport of this pull request to the 3.8 branch.

…ythonGH-14870) Repeat the command line arguments most recently entered before so the user can edit them. (cherry picked from commit 35b87e6) Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

bedevere-bot · 2019-07-21T15:37:49Z

GH-14882 is a backport of this pull request to the 3.7 branch.

…H-14870) Repeat the command line arguments most recently entered before so the user can edit them. (cherry picked from commit 35b87e6) Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

miss-islington · 2019-07-21T19:28:56Z

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2019-07-21T19:28:57Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington · 2019-07-21T19:34:12Z

Thanks @nsiregar for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

…ythonGH-14870) Repeat the command line arguments most recently entered before so the user can edit them. (cherry picked from commit 35b87e6) Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

bedevere-bot · 2019-07-21T19:34:22Z

GH-14893 is a backport of this pull request to the 3.8 branch.

terryjreedy · 2019-07-21T19:41:06Z

@Mariatta I have re-added 'needs backport to 3.8' twice with no response at all after several minutes

Mariatta · 2019-07-21T20:01:02Z

The last one seemed to work

…H-14870) Repeat the command line arguments most recently entered before so the user can edit them. (cherry picked from commit 35b87e6) Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

…ython#14870) Repeat the command line arguments most recently entered before so the user can edit them.

nsiregar requested a review from terryjreedy as a code owner July 20, 2019 16:35

the-knights-who-say-ni added the CLA signed label Jul 20, 2019

bedevere-bot added the awaiting review label Jul 20, 2019

terryjreedy changed the title ~~bpo-3726: IDLE: Improve menu option run customized~~ bpo-37627: IDLE: Improve menu option run customized Jul 20, 2019

bpo-37627: IDLE: Improve menu option run customized

cf1aee9

nsiregar force-pushed the bpo-37627-minor-improvement-idle branch from 85b1f40 to cf1aee9 Compare July 20, 2019 16:55

terryjreedy requested changes Jul 20, 2019

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Jul 20, 2019

terryjreedy changed the title ~~bpo-37627: IDLE: Improve menu option run customized~~ bpo-37627: IDLE -- persist custom run arguments Jul 21, 2019

terryjreedy self-assigned this Jul 21, 2019

terryjreedy added needs backport to 3.7 type-feature A feature request or enhancement labels Jul 21, 2019

terryjreedy changed the title ~~bpo-37627: IDLE -- persist custom run arguments~~ bpo-37627: Initialize IDLE Custom Run dialog with previous entires Jul 21, 2019

terryjreedy changed the title ~~bpo-37627: Initialize IDLE Custom Run dialog with previous entires~~ bpo-37627: Initialize IDLE Custom Run dialog with previous entries Jul 21, 2019

terryjreedy added 3 commits July 20, 2019 20:33

Update 2019-07-20-23-33-53.bpo-37627.dQhUNB.rst

e5bde5e

Delete mainmenu.py

e347e5b

Delete editor.py

01d7b17

terryjreedy added the DO-NOT-MERGE label Jul 21, 2019

terryjreedy added 4 commits July 20, 2019 20:47

Revert "Delete editor.py"

6914516

This reverts commit 01d7b17.

Revert "Delete mainmenu.py"

7d4e3be

This reverts commit e347e5b.

Revert mainmenu change.

220bddc

Revert editor.py change

b657d36

terryjreedy removed the DO-NOT-MERGE label Jul 21, 2019

Make cli_args always a list; doc and test.

7a6acc9

bedevere-bot added the awaiting merge label Jul 21, 2019

terryjreedy merged commit 35b87e6 into python:master Jul 21, 2019

bedevere-bot removed the awaiting merge label Jul 21, 2019

bedevere-bot removed the needs backport to 3.8 label Jul 21, 2019

bedevere-bot removed the needs backport to 3.7 label Jul 21, 2019

terryjreedy added the needs backport to 3.8 label Jul 21, 2019

terryjreedy added needs backport to 3.8 and removed needs backport to 3.8 labels Jul 21, 2019

bedevere-bot removed the needs backport to 3.8 label Jul 21, 2019

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…

7a5309c

…ython#14870) Repeat the command line arguments most recently entered before so the user can edit them.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…

d5a6478

…ython#14870) Repeat the command line arguments most recently entered before so the user can edit them.

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-37627: Initialize IDLE Custom Run dialog with previous entries (p…

cdb047b

…ython#14870) Repeat the command line arguments most recently entered before so the user can edit them.

Uh oh!

Uh oh!

Conversation

nsiregar commented Jul 20, 2019 • edited by terryjreedy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy commented Jul 20, 2019

Uh oh!

terryjreedy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jul 20, 2019

Uh oh!

rhettinger commented Jul 20, 2019

Uh oh!

terryjreedy commented Jul 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nsiregar commented Jul 21, 2019

Uh oh!

miss-islington commented Jul 21, 2019

Uh oh!

bedevere-bot commented Jul 21, 2019

Uh oh!

bedevere-bot commented Jul 21, 2019

Uh oh!

bedevere-bot commented Jul 21, 2019

Uh oh!

miss-islington commented Jul 21, 2019

Uh oh!

miss-islington commented Jul 21, 2019

Uh oh!

miss-islington commented Jul 21, 2019

Uh oh!

bedevere-bot commented Jul 21, 2019

Uh oh!

terryjreedy commented Jul 21, 2019

Uh oh!

Mariatta commented Jul 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nsiregar commented Jul 20, 2019 •

edited by terryjreedy

Loading

terryjreedy left a comment •

edited

Loading

terryjreedy commented Jul 21, 2019 •

edited

Loading