Skip to content

[3.8] bpo-36564: Fix infinite loop in email folding logic (GH-12732)#14797

Merged
miss-islington merged 1 commit intopython:3.8from
miss-islington:backport-f69d5c6-3.8
Jul 16, 2019
Merged

[3.8] bpo-36564: Fix infinite loop in email folding logic (GH-12732)#14797
miss-islington merged 1 commit intopython:3.8from
miss-islington:backport-f69d5c6-3.8

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jul 16, 2019 •
edited by bedevere-bot
Loading

As far as I can tell, this infinite loop would be triggered if:

  1. The value being folded contains a single word (no spaces) longer than
    max_line_length
  2. The max_line_length is shorter than the encoding's name + 9
    characters.

bpo-36564: https://bugs.python.org/issue36564
(cherry picked from commit f69d5c6)

Co-authored-by: Paul Ganssle pganssle@users.noreply.github.com

https://bugs.python.org/issue36564

@pganssle @miss-islington
Fix infinite loop in email folding logic (pythonGH-12732)
31c36d1 
As far as I can tell, this infinite loop would be triggered if:

1. The value being folded contains a single word (no spaces) longer than
   max_line_length
2. The max_line_length is shorter than the encoding's name + 9
   characters.

bpo-36564: https://bugs.python.org/issue36564
(cherry picked from commit f69d5c6)

Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
@miss-islington miss-islington requested a review from a team as a code owner July 16, 2019 17:50
@bedevere-bot bedevere-bot mentioned this pull request Jul 16, 2019
Merged
@warsaw warsaw changed the title [3.8] Fix infinite loop in email folding logic (GH-12732) [3.8] bpo-36564: Fix infinite loop in email folding logic (GH-12732) Jul 16, 2019
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jul 16, 2019

@pganssle and @warsaw: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6a2aec0 into python:3.8 Jul 16, 2019
@miss-islington miss-islington deleted the backport-f69d5c6-3.8 branch July 16, 2019 18:08
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jul 16, 2019

@pganssle and @warsaw: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jul 16, 2019

@pganssle and @warsaw: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jul 16, 2019

@pganssle and @warsaw: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @warsaw @the-knights-who-say-ni @bedevere-bot @pganssle