gh-143050: add helper _PyLong_InitTag()#147956
Open
skirpichev wants to merge 3 commits intopython:mainfrom
Open
gh-143050: add helper _PyLong_InitTag()#147956skirpichev wants to merge 3 commits intopython:mainfrom
skirpichev wants to merge 3 commits intopython:mainfrom
Conversation
With this we can assume, that _PyLong_Set*() operate on non-immortal integers.
vstinner
reviewed
Apr 1, 2026
| { | ||
| assert(PyLong_Check(op)); | ||
| op->long_value.lv_tag = 1; /* non-immortal zero */ | ||
| op->long_value.ob_digit[0] = 0; |
Member
There was a problem hiding this comment.
I would prefer to only initialize the tag and so rename the function to _PyLong_InitTag().
op->long_value.ob_digit[0] = 0; is only used (needed) by long_alloc(). All other functions using _PyLong_Init() will rewrite ob_digit[0] immediately and so it's inefficient.
Member
Author
There was a problem hiding this comment.
I think this may trigger a compiler warning. I did renaming, lets do another change in a second commit.
skirpichev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we can assume, that _PyLong_Set*() operate on non-immortal integers.