Skip to content

gh-146615: Fix format specifiers in extension modules#146617

Merged
serhiy-storchaka merged 3 commits intopython:mainfrom
sunmy2019:gh-146615-2
Mar 31, 2026
Merged

gh-146615: Fix format specifiers in extension modules#146617
serhiy-storchaka merged 3 commits intopython:mainfrom
sunmy2019:gh-146615-2

Conversation

@sunmy2019
Copy link
Copy Markdown
Member

@sunmy2019 sunmy2019 commented Mar 30, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 30, 2026
Open
@sunmy2019 sunmy2019 mentioned this pull request Mar 30, 2026
Closed
emmatyping
emmatyping reviewed Mar 30, 2026
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Mar 30, 2026
View reviewed changes
@picnixz
Copy link
Copy Markdown
Member

picnixz commented Mar 30, 2026

See #146620 (comment) for the rationale of skip news

serhiy-storchaka
serhiy-storchaka approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 30, 2026
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review March 30, 2026 17:10
StanFromIreland
StanFromIreland approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for _zoneinfo.c

kumaraditya303
kumaraditya303 approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncio changes LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 1c396e1 into python:main Mar 31, 2026
65 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 31, 2026

Thanks @sunmy2019 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 31, 2026

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.14

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 31, 2026

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.13

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
@sunmy2019 @serhiy-storchaka
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
bdb9d8a 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 31, 2026

GH-146652 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 31, 2026
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.13 bugs and security fixes label Mar 31, 2026
@serhiy-storchaka serhiy-storchaka removed their assignment Mar 31, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
@sunmy2019 @serhiy-storchaka
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
e3e88c7 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
@sunmy2019 @serhiy-storchaka
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
de63d17 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka added a commit that referenced this pull request Mar 31, 2026
@serhiy-storchaka @sunmy2019
[3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…
58c7259 
…) (GH-146652)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
@serhiy-storchaka @sunmy2019
[3.13] pythongh-146615: Fix format specifiers in extension modules (p…
6e5c933 
…ythonGH-146617) (pythonGH-146652)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
@maurycy
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa 
* main:
  pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
  pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
  pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
  pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
  pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
  pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
  pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
  pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
  pythongh-146238: Support half-floats in the array module (python#146242)
  pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
  pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
  pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
serhiy-storchaka added a commit that referenced this pull request Mar 31, 2026
@serhiy-storchaka @sunmy2019
[3.13] gh-146615: Fix format specifiers in extension modules (GH-146617…
fc1c644 
…) (GH-146652) (GH-146658)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 31, 2026

GH-147704 is a backport of this pull request to the 3.14 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@emmatyping emmatyping emmatyping left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sunmy2019 @picnixz @serhiy-storchaka @emmatyping @kumaraditya303 @StanFromIreland