gh-146587: fix type slot assignment incase of multiple slots for same name#146593
Open
kumaraditya303 wants to merge 4 commits intopython:mainfrom
Open
gh-146587: fix type slot assignment incase of multiple slots for same name#146593kumaraditya303 wants to merge 4 commits intopython:mainfrom
kumaraditya303 wants to merge 4 commits intopython:mainfrom
Conversation
kumaraditya303
changed the title
kumaraditya303
added
the
interpreter-core
Contributor
|
@kumaraditya303 Could you please take a look at sergey-miryanov@f26545a? WDYT? |
Contributor
Author
It looks the same as this one except more complicated, you are also checking that if a slot has duplicates then only one of them should be filled isn't it? I am not sure that the loop is big enough that there would be performance difference. |
Contributor
|
Yeah, it looks the same. Except we don’t need to iterate all slotdefs, because we precalculates dup indexes. |
Contributor
|
I wrote answer before your edit. I don’t remember exactly how items in slotdefs, about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__radd__fallback regression #146587