[3.8] bpo-18374: fix wrong col_offset of some ast.BinOp instances (GH-14607)#14653
Merged
miss-islington merged 1 commit intopython:3.8from Jul 8, 2019
Merged
Conversation
…-14607) Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the correct st node to copy the line and col_offset from in ast.c. (cherry picked from commit 110a47c) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
ilevkivskyi
approved these changes
Jul 8, 2019
Contributor
Author
|
@cfbolz and @ilevkivskyi: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@cfbolz and @ilevkivskyi: Status check is done, and it's a success ✅ . |
2 similar comments
Contributor
Author
|
@cfbolz and @ilevkivskyi: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@cfbolz and @ilevkivskyi: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.
(cherry picked from commit 110a47c)
Co-authored-by: Carl Friedrich Bolz-Tereick cfbolz@gmx.de
https://bugs.python.org/issue18374