Skip to content

Doc: Fix missing negation.#14640

Merged
miss-islington merged 2 commits intopython:masterfrom
JulienPalard:doc-not-word-character
Sep 11, 2019
Merged

Doc: Fix missing negation.#14640
miss-islington merged 2 commits intopython:masterfrom
JulienPalard:doc-not-word-character

Conversation

@JulienPalard
Copy link
Copy Markdown
Member

@JulienPalard JulienPalard commented Jul 7, 2019 •
edited by miss-islington
Loading

Reported by Hug Capella on docs@.

Automerge-Triggered-By: @matrixise

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 7, 2019
aeros
aeros suggested changes Jul 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a minor phrasing improvement suggestion, I would recommend changing it from:

... If the :const:LOCALE flag is used, matches characters considered alphanumeric in the current locale and the underscore.

to:

... If the :const:LOCALE flag is used, matches characters which are considered alphanumeric in the current locale and the underscore.

eamanu
eamanu approved these changes Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulienPalard
Copy link
Copy Markdown
Member Author

JulienPalard commented Jul 12, 2019

@aeros167 So you mean you're suggestion is to change:

If the :const:LOCALE flag is
used, matches characters neither considered alphanumeric in the current locale
nor the underscore.

to:

If the :const:LOCALE flag is
used, matches characters which are neither considered alphanumeric in the current locale
nor the underscore.

?

@aeros
Copy link
Copy Markdown
Contributor

aeros commented Jul 12, 2019 •
edited
Loading

@JulienPalard I'll submit the actual suggestion instead of just leaving it as a comment so it's easier to see, and yes the missing neither was a typo.

aeros
aeros suggested changes Jul 12, 2019
View reviewed changes
@JulienPalard @aeros
Update Doc/library/re.rst
4d907bb 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
matrixise
matrixise approved these changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 11, 2019

@JulienPalard: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1fae844 into python:master Sep 11, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 11, 2019

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@JulienPalard @miss-islington
Doc: Fix missing negation. (pythonGH-14640)
cd981cd 
Reported by Hug Capella on docs@.

Automerge-Triggered-By: @matrixise
(cherry picked from commit 1fae844)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15984 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@JulienPalard @miss-islington
Doc: Fix missing negation. (pythonGH-14640)
6775571 
Reported by Hug Capella on docs@.

Automerge-Triggered-By: @matrixise
(cherry picked from commit 1fae844)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15985 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @JulienPalard
Doc: Fix missing negation. (GH-14640)
05d692b 
Reported by Hug Capella on docs@.

Automerge-Triggered-By: @matrixise
(cherry picked from commit 1fae844)

Co-authored-by: Julien Palard <julien@palard.fr>
matrixise pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @JulienPalard @matrixise
Doc: Fix missing negation. (GH-14640) (GH-15985)
bf0c76c 
Reported by Hug Capella on docs@.

Automerge-Triggered-By: @matrixise
(cherry picked from commit 1fae844)

Co-authored-by: Julien Palard <julien@palard.fr>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@JulienPalard @DinoV
Doc: Fix missing negation. (pythonGH-14640)
c36209f 
Reported by Hug Capella on docs@.



Automerge-Triggered-By: @matrixise
@JulienPalard JulienPalard deleted the doc-not-word-character branch October 22, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes

+2 more reviewers

@aeros aeros aeros requested changes

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JulienPalard @aeros @miss-islington @bedevere-bot @matrixise @eamanu @the-knights-who-say-ni