gh-146004: propagate all -X options to multiprocessing child processes#146005
gh-146004: propagate all -X options to multiprocessing child processes#146005gpshead merged 2 commits intopython:mainfrom
Conversation
|
Auto-backported test will probably fail CI as the test includes new -X options that older releases don't have. I'll clean that up in the backport PR branches. |
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ocesses (pythonGH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes. (cherry picked from commit 1efe441) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
Sorry, @gpshead, I could not cleanly backport this to |
|
GH-146552 is a backport of this pull request to the 3.14 branch. |
…rocesses (GH-146005) (#146552) gh-146004: propagate all -X options to multiprocessing child processes (GH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes. (cherry picked from commit 1efe441) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
|
|
|
|
|
|
test_support fails on Windows buildbots: I don't see the relationship with the change. |
|
|
I think the problem is (The problem is likely because we are using |
|
I suggest using tempfile.gettempdir(). |
|
I suggest just using |
|
I won't be able to get to this today. That makes sense as a fix. |
|
No worries! Chris handled it already: #146580 |
| ['-X', 'dev'], | ||
| ['-Wignore', '-X', 'dev'], | ||
| ['-X', 'cpu_count=4'], | ||
| ['-X', 'disable-remote-debug'], |
There was a problem hiding this comment.
This is documented as
-X disable_remote_debug
with underscores.
Furthermore, -X presite=package.module, -X gil=0,1 and some more aren't listed here.
Not a big issue IMHO, since this just tests that whatever we pass in is returned from args_from_interpreter_flags?
There was a problem hiding this comment.
So an alternative fix for #146580 would be to just remove ['-X', 'pycache_prefix=/tmp/pycache'],?
Sorry, didn't realize earlier, just stumbled over it now ...
See the issue for details. Our list of -X options to opt-in was overlooking a lot. CI and buildbot tests on these may prove interesting.
-Xoptions do not auto-propagate to multiprocessing processes #146004