gh-145701: Fix __classdict__ & __conditional_annotations__ in class-scope inlined comprehensions#145702
Merged
Merged
Conversation
…in class-scope inlined comprehensions
JelleZijlstra
approved these changes
Mar 9, 2026
gpshead
approved these changes
Mar 9, 2026
gpshead
added
needs backport to 3.13
Member
|
(opportunistically applying the backport labels - I'm not sure how far back this will need to go) |
|
Thanks @StanFromIreland for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 9, 2026
…in class-scope inlined comprehensions (pythonGH-145702) (cherry picked from commit 63eaaf9) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 9, 2026
…in class-scope inlined comprehensions (pythonGH-145702) (cherry picked from commit 63eaaf9) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-145710 is a backport of this pull request to the 3.14 branch. |
|
GH-145711 is a backport of this pull request to the 3.13 branch. |
Member
Author
I can repro on 3.13/3.14. |
Member
|
I think I introduced the bug in 3.12, so yes this should be backported |
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 9, 2026
… in class-scope inlined comprehensions (GH-145702) (#145710) (cherry picked from commit 63eaaf9) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> * Add `:oss-fuzz:` supports Backports part of 255e79f. Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
gpshead
pushed a commit
that referenced
this pull request
Mar 9, 2026
… in class-scope inlined comprehensions (GH-145702) (#145711) * gh-145701: Fix `__classdict__` & `__conditional_annotations__` in class-scope inlined comprehensions (GH-145702) (cherry picked from commit 63eaaf9) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> * Add `:oss-fuzz:` macro support Backports part of 255e79f. --------- Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…in class-scope inlined comprehensions (pythonGH-145702)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extension of fedbf77.
SystemErroron__classdict__/__conditional_annotations__in class-scope inlined comprehensions #145701