Skip to content

[3.13] gh-129259: Fix AIX build failures caused by incorrect struct alignment#144917

Merged
ambv merged 1 commit into
python:3.13from
rsmkaminskas:gh-129259
Mar 24, 2026
Merged

[3.13] gh-129259: Fix AIX build failures caused by incorrect struct alignment#144917
ambv merged 1 commit into
python:3.13from
rsmkaminskas:gh-129259

Conversation

@rsmkaminskas

@rsmkaminskas rsmkaminskas commented Feb 17, 2026

Copy link
Copy Markdown

This PR fixes the AIX build failures mentioned in issue #129259.

Note In 3.14, the _Py_BackoffCounter bit field structure was replaced with a uint16_t

…ignment by adding AIX-specific #pragma pack directives.
@python-cla-bot

python-cla-bot Bot commented Feb 17, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@rsmkaminskas rsmkaminskas changed the title gh-129259: Fix AIX build failures caused by incorrect struct alignment [3.13] gh-129259: Fix AIX build failures caused by incorrect struct alignment Feb 17, 2026
@rsmkaminskas

Copy link
Copy Markdown
Author

Hi @encukou , could you please review this PR?

@encukou

encukou commented Feb 18, 2026

Copy link
Copy Markdown
Member

Oh, wait, I missed that this only fails on 3.13.
We generally don't backport fixes to maintenance branches, the same would apply to a 3.13-only fix. But we can make an exception; and I guess we should, for this hard-to-diagnose issue.

@ayappanec, as the AIX expert, does this look good?

@ayappanec

Copy link
Copy Markdown
Contributor

I guess this issue happens with OpenXL compiler (IBM's clang compiler) which by default passes "-maltivec" that enforces strict alignment rules.
@encukou The changes looks good.

@ambv
ambv merged commit 793a86f into python:3.13 Mar 24, 2026
43 checks passed
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit 793a86f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1856) and take a look at the build logs.
  4. Check if the failure is related to this commit (793a86f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1856

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants