gh-140025: Fix Fix queue.SimpleQueue.__sizeof__() #143137
Open
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Dec 24, 2025
Modules/_queuemodule.c
Outdated
Comment on lines
241
to
243
| static PyObject * | ||
| simplequeue_sizeof(PyObject *op, PyObject *Py_UNUSED(ignored)) | ||
| { |
Contributor
There was a problem hiding this comment.
This needs a critical section (a lock for the queue). The simplest way is to use "Argument Clinic" like the other functions.
Something like:
/*[clinic input]
@critical_section
_queue.SimpleQueue.__sizeof__ -> Py_ssize_t
Returns size in memory, in bytes.
[clinic start generated code]*/
static Py_ssize_t
simplequeue_sizeof_impl(simplequeueobject *self)
/*[clinic end generated code: output=3303f008eaa6a0a5 input=9b51620c76fc4507]*/
Then run make clinic to regenerate the bindings.
Modules/_queuemodule.c
Outdated
| _QUEUE_SIMPLEQUEUE_PUT_METHODDEF | ||
| _QUEUE_SIMPLEQUEUE_PUT_NOWAIT_METHODDEF | ||
| _QUEUE_SIMPLEQUEUE_QSIZE_METHODDEF | ||
| {"__sizeof__", (PyCFunction)simplequeue_sizeof, METH_NOARGS, NULL}, |
Contributor
There was a problem hiding this comment.
You'll also need to change this to use the Argument Clinic methoddef (like above).
Lib/test/test_queue.py
Outdated
|
|
||
| def test_simplequeue_sizeof_reflects_buffer_growth(self): | ||
| q = self.type2test() | ||
| before = q.__sizeof__() |
Contributor
There was a problem hiding this comment.
A few changes:
- Don't use ctypes (no support for that in wasi)
- Use
support.calcobjsize - Use
sys.getsizeof()instead of calling__sizeof__directly
Contributor
Author
|
@colesbury thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !
queue.SimpleQueue.__sizeof__()ignores the underlying data structure #140025