Skip to content

gh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 #143136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 5 commits into from
Dec 24, 2025
Merged

gh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 #143136

serhiy-storchaka merged 5 commits into from
Dec 24, 2025
+5 −1

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Dec 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 24, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Dec 24, 2025
View reviewed changes
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 24, 2025
@StanFromIreland @vstinner
Third times the charm…?
bd9c365 
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka
serhiy-storchaka approved these changes Dec 24, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry for been so picky.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Dec 24, 2025

Sorry for been so picky.

No worries, I was busy and the commits were not as good as they should be. Merry Christmas!

@serhiy-storchaka serhiy-storchaka merged commit 3509fa5 into python:main Dec 24, 2025
50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 24, 2025

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2025
@StanFromIreland @miss-islington
pythongh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 (pythonGH…
f13229c 
…-143136)

(cherry picked from commit 3509fa5a12855805f0c6d7f8a6a3b162744a8fd4)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 24, 2025

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3509fa5a12855805f0c6d7f8a6a3b162744a8fd4 3.13

@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2025

GH-143153 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 24, 2025
@serhiy-storchaka serhiy-storchaka changed the title gh-143135: Make PYTHONINSPECT check consistent gh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 Dec 24, 2025
serhiy-storchaka pushed a commit that referenced this pull request Dec 24, 2025
@miss-islington @StanFromIreland
[3.14] gh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 (GH-143136…
73c40bb 
…) (GH-143153)

(cherry picked from commit 3509fa5)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the PYTHONINSPECT branch December 24, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

needs backport to 3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @vstinner @serhiy-storchaka