Skip to content

gh-143006: add type check in float_richcompare() #143053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skirpichev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-143006: add type check in float_richcompare() #143053

skirpichev wants to merge 1 commit into from
+17 −0

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Dec 21, 2025 •
edited by bedevere-app bot
Loading

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 21, 2025
@bedevere-app bedevere-app bot mentioned this pull request Dec 21, 2025
Open
@skirpichev skirpichev requested a review from vstinner December 21, 2025 22:11
@skirpichev
Copy link
Contributor Author

skirpichev commented Dec 21, 2025

I'm not sure if it worth. But the check is cheap (when it is False).

See issue thread for alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skirpichev