Skip to content

[3.14] gh-142145: relax the no-longer-quadratic test timing (GH-143030) #143031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 2 commits into from
Dec 21, 2025
Merged

[3.14] gh-142145: relax the no-longer-quadratic test timing (GH-143030) #143031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0196ab
gh-142145: relax the no-longer-quadratic test timing (GH-143030)
gpshead Dec 20, 2025
0a44fc5
Merge branch '3.14' into backport-8d2d7bb-3.14
gpshead Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Lib/test/test_minidom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def testAppendChild(self):
self.assertEqual(dom.documentElement.childNodes[-1].data, "Hello")
dom.unlink()

@support.requires_resource('cpu')
def testAppendChildNoQuadraticComplexity(self):
impl = getDOMImplementation()

Expand All @@ -182,14 +183,18 @@ def testAppendChildNoQuadraticComplexity(self):
children = [newdoc.createElement(f"child-{i}") for i in range(1, 2 ** 15 + 1)]
element = top_element

start = time.time()
start = time.monotonic()
for child in children:
element.appendChild(child)
element = child
end = time.time()
end = time.monotonic()

# This example used to take at least 30 seconds.
self.assertLess(end - start, 1)
# Conservative assertion due to the wide variety of systems and
# build configs timing based tests wind up run under.
# A --with-address-sanitizer --with-pydebug build on a rpi5 still
# completes this loop in <0.5 seconds.
self.assertLess(end - start, 4)

def testSetAttributeNodeWithoutOwnerDocument(self):
# regression test for gh-142754
Expand Down
Loading