Skip to content

gh-142999: Make test_venv use sysconfig._get_implementation().lower() instead of hardcoding "python" #143000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

gh-142999: Make test_venv use sysconfig._get_implementation().lower() instead of hardcoding "python" #143000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Lib/test/test_venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
except ImportError:
ctypes = None

# Implementation name for lib directory (e.g., 'python' for CPython, 'pypy' for PyPy)
IMPL_NAME = sysconfig._get_implementation().lower()

# Platforms that set sys._base_executable can create venvs from within
# another venv, so no need to skip tests that require venv.create().
requireVenvCreate = unittest.skipUnless(
Expand Down Expand Up @@ -75,7 +78,7 @@ def setUp(self):
self.include = 'Include'
else:
self.bindir = 'bin'
self.lib = ('lib', f'python{sysconfig._get_python_version_abi()}')
self.lib = ('lib', f'{IMPL_NAME}{sysconfig._get_python_version_abi()}')
self.include = 'include'
executable = sys._base_executable
self.exe = os.path.split(executable)[-1]
Expand Down Expand Up @@ -357,8 +360,8 @@ def test_sysconfig_symlinks(self):
('bin',),
('include',),
('lib',),
('lib', 'python%d.%d' % sys.version_info[:2]),
('lib', 'python%d.%d' % sys.version_info[:2], 'site-packages'),
('lib', '%s%d.%d' % (IMPL_NAME, *sys.version_info[:2])),
('lib', '%s%d.%d' % (IMPL_NAME, *sys.version_info[:2]), 'site-packages'),
)

def create_contents(self, paths, filename):
Expand Down Expand Up @@ -688,7 +691,7 @@ def test_zippath_from_non_installed_posix(self):
os.makedirs(libdir)
landmark = os.path.join(libdir, "os.py")
abi_thread = "t" if sysconfig.get_config_var("Py_GIL_DISABLED") else ""
stdlib_zip = f"python{sys.version_info.major}{sys.version_info.minor}{abi_thread}"
stdlib_zip = f"{IMPL_NAME}{sys.version_info.major}{sys.version_info.minor}{abi_thread}"
zip_landmark = os.path.join(non_installed_dir,
platlibdir,
stdlib_zip)
Expand Down
Loading