bpo-30246: fix several error messages which only mention bytes in struct#1421
Conversation
|
@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Yhg1s, @serhiy-storchaka and @mdickinson to be potential reviewers. |
| "iterative unpacking requires a bytes length " | ||
| "multiple of %zd", | ||
| "iterative unpacking requires a bytes-like object of " | ||
| "length multiple of %zd", |
There was a problem hiding this comment.
maybe bytes-like object of its length is multiple of?
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Don't haste with merging this patch. I'll try to find the past discussion about the similar issue.
| PyErr_Format(StructError, | ||
| "iterative unpacking requires a bytes length " | ||
| "multiple of %zd", | ||
| "iterative unpacking requires a buffer of " |
There was a problem hiding this comment.
I delibrately discard it. Now the error messages in struct all get a "requires a buffer of %d bytes" format.
There was a problem hiding this comment.
“. . . a buffer of a multiple of . . .” would read better to me. Or simpler: “requires a multiple of . . . bytes”.
|
What's the status of this PR @serhiy-storchaka ? |
|
Is it okay for me to merge this now @vadmium @serhiy-storchaka ? |
|
The changes look okay to me. |
|
Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Sorry, @zhangyangyu, I could not cleanly backport this to |
|
GH-3561 is a backport of this pull request to the 3.6 branch. |
10 participants
No description provided.