-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-141004: Document missing PyThread* APIs
#141810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
84ba453
Document legacy PyThread_*lock APIs
ZeroIntensity ec3778e
Eliminate some redundancy.
ZeroIntensity 1523e76
Document the remaining PyThread* APIs.
ZeroIntensity f01a9f8
Fix Sphinx ref.
ZeroIntensity 85fea13
Fix typo.
ZeroIntensity 88d905d
Set namespace to NULL for PyLockStatus things.
ZeroIntensity f50cbbb
Fix typo.
ZeroIntensity 36c8ebc
Apply suggestions from code review
ZeroIntensity 2338b2b
Add note about Py_MakePendingCalls()
ZeroIntensity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyErr_CheckSignals() may be more appropriate than Py_MakePendingCalls(), no? Currently, it seems like Py_MakePendingCalls() is preferred.
Py_MakePendingCalls() is a superset of PyErr_CheckSignals(), so I'm fine with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use
Py_MakePendingCalls, especially considering we use it ourselves in_thread.lock.