Skip to content

gh-140729: Fix subprocess handling in test_process_pool_executor_pickle #141688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Nov 18, 2025
Merged

gh-140729: Fix subprocess handling in test_process_pool_executor_pickle #141688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Lib/test/test_profiling/test_sampling_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,6 +3311,8 @@ def test_native_frames_disabled(self):
self.assertNotIn("<native>", output)


@requires_subprocess()
@skip_if_not_supported
class TestProcessPoolExecutorSupport(unittest.TestCase):
"""
Test that ProcessPoolExecutor works correctly with profiling.sampling.
Expand Down Expand Up @@ -3339,12 +3341,15 @@ def worker(x):
"-d", "5",
"-i", "100000",
script,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True
) as proc:
proc.wait(timeout=SHORT_TIMEOUT)
stdout = proc.stdout.read()
stderr = proc.stderr.read()
try:
stdout, stderr = proc.communicate(timeout=SHORT_TIMEOUT)
except subprocess.TimeoutExpired:
proc.kill()
stdout, stderr = proc.communicate()

if "PermissionError" in stderr:
self.skipTest("Insufficient permissions for remote profiling")
Expand Down
Loading