gh-62480: De-personalize "Mocking Unbound Methods" section in unittest.mock examples
#141322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
oklena
changed the title
CAM-Gerlach
added
needs backport to 3.13
picnixz
changed the title
picnixz
changed the title
unittest.mock examples
picnixz
reviewed
Nov 9, 2025
CAM-Gerlach
reviewed
Nov 9, 2025
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Some further textual refinements and improvements
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
CAM-Gerlach
reviewed
Nov 9, 2025
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
approved these changes
Nov 9, 2025
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM now, thanks @oklena !
|
Thanks @oklena for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
…unittest.mock` examples (pythonGH-141322) * Rewrite Mocking Unbound Methods paragraph to second person (cherry picked from commit ec85d3c) Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-141324 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
…unittest.mock` examples (pythonGH-141322) * Rewrite Mocking Unbound Methods paragraph to second person (cherry picked from commit ec85d3c) Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-141325 is a backport of this pull request to the 3.13 branch. |
CAM-Gerlach
added a commit
that referenced
this pull request
Nov 9, 2025
…`unittest.mock` examples (GH-141322) (#141324) gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322) * Rewrite Mocking Unbound Methods paragraph to second person (cherry picked from commit ec85d3c) Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
CAM-Gerlach
added a commit
that referenced
this pull request
Nov 10, 2025
…`unittest.mock` examples (GH-141322) (#141325) gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322) * Rewrite Mocking Unbound Methods paragraph to second person (cherry picked from commit ec85d3c) Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…unittest.mock` examples (python#141322) * Rewrite Mocking Unbound Methods paragraph to second person Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote two first sentenced and the last sentence of Mocking Unbound Methods paragraph to second person.
📚 Documentation preview 📚: https://cpython-previews--141322.org.readthedocs.build/