gh-83926: BlockingIOError characters_written is byte count #141215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak doc to highlight it's the number of bytes.
bedevere-app
bot
added
awaiting review
docs
Contributor
Author
|
This gets set by BufferedIO which always works in bytes: cpython/Modules/_io/bufferedio.c Line 756 in c0c6514 |
vstinner
approved these changes
Dec 4, 2025
Member
|
And backport? |
vstinner
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…honGH-141215) (cherry picked from commit e12c744) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…honGH-141215) (cherry picked from commit e12c744) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
|
GH-142815 is a backport of this pull request to the 3.13 branch. |
|
GH-142816 is a backport of this pull request to the 3.14 branch. |
Member
Good idea. I backported the doc change to 3.13 and 3.14. |
vstinner
pushed a commit
that referenced
this pull request
Dec 16, 2025
vstinner
pushed a commit
that referenced
this pull request
Dec 16, 2025
Contributor
Author
|
👍 for backports; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak doc to highlight it's the number of bytes.
📚 Documentation preview 📚: https://cpython-previews--141215.org.readthedocs.build/