gh-140764: Make "missed comma" syntax warning less cryptic #140893
Conversation
|
I was just working on this :) I was thinking of suggesting something like (as hinted): 1 Keep “perhaps” -> stays consistent with Python’s style. |
|
@alonme In the future, when someone says they are working on something in the issue thread, please don't open a PR. |
|
@StanFromIreland Sure, is there a rough guideline to how long after someone "claims" an issue is it okay to try and tackle it? |
I'd recommend you wait at least three weeks, you can always ask. |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
This is not only for sequence elements. You get the same warning for set and dict which are not sequences. And for function arguments.
>>> {(1, 2) (3, 4)}
<python-input-0>:1: SyntaxWarning: 'tuple' object is not callable; perhaps you missed a comma?
Traceback (most recent call last):
File "<python-input-0>", line 1, in <module>
{(1, 2) (3, 4)}
~~~~~~~^^^^^^
TypeError: 'tuple' object is not callable
>>> print((1, 2) (3, 4))
<python-input-1>:1: SyntaxWarning: 'tuple' object is not callable; perhaps you missed a comma?
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
print((1, 2) (3, 4))
~~~~~~~^^^^^^
TypeError: 'tuple' object is not callable
|
Given that mentioning "sequence elements" isn't applicable to all scenarios, how about we simply make it generic and end the warning with |
5 participants
Uh oh!
There was an error while loading. Please reload this page.