Skip to content

[3.8] bpo-37261: Document sys.unraisablehook corner cases (GH-14059)#14089

Merged
miss-islington merged 1 commit intopython:3.8from
miss-islington:backport-212646c-3.8
Jun 14, 2019
Merged

[3.8] bpo-37261: Document sys.unraisablehook corner cases (GH-14059)#14089
miss-islington merged 1 commit intopython:3.8from
miss-islington:backport-212646c-3.8

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jun 14, 2019

Document reference cycle and resurrected objects issues in
sys.unraisablehook() and threading.excepthook() documentation.

Fix test.support.catch_unraisable_exception(): exit() no longer
ignores unraisable exceptions.

Fix test_io test_writer_close_error_on_close(): use a second
catch_unraisable_exception() to catch the BufferedWriter unraisable
exception.
(cherry picked from commit 212646c)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37261

Document reference cycle and resurrected objects issues in
sys.unraisablehook() and threading.excepthook() documentation.

Fix test.support.catch_unraisable_exception(): __exit__() no longer
ignores unraisable exceptions.

Fix test_io test_writer_close_error_on_close(): use a second
catch_unraisable_exception() to catch the BufferedWriter unraisable
exception.
(cherry picked from commit 212646c)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3b976d1 into python:3.8 Jun 14, 2019
@miss-islington miss-islington deleted the backport-212646c-3.8 branch June 14, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants