Skip to content

[3.8] bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074) - #14078

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-0755945-3.8
Jun 14, 2019
Merged

miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-0755945-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 14, 2019 •

Copy link
Copy Markdown
Contributor

Join the thread to prevent leaking a running thread and leaking a
reference.

Cleanup also the test:

  • asyncioWindowsProactorEventLoopPolicy became the default policy,
    there is no need to set it manually.
  • Only start the thread once the loop is running.
  • Use a shorter sleep in the thread (100 ms rather than 1 sec).
  • Use close_loop(loop) rather than loop.close().
  • Use longer variable names.
    (cherry picked from commit 0755945)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37278

Join the thread to prevent leaking a running thread and leaking a
reference.

Cleanup also the test:

* asyncioWindowsProactorEventLoopPolicy became the default policy,
  there is no need to set it manually.
* Only start the thread once the loop is running.
* Use a shorter sleep in the thread (100 ms rather than 1 sec).
* Use close_loop(loop) rather than loop.close().
* Use longer variable names.
(cherry picked from commit 0755945)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 8b66dbb into python:3.8 Jun 14, 2019
@miss-islington
miss-islington deleted the backport-0755945-3.8 branch June 14, 2019 11:53
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants