Skip to content

[3.8] bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074) - #14077

Closed
miss-islington wants to merge 1 commit into
python:3.8from
miss-islington:backport-0755945-3.8
Closed

miss-islington wants to merge 1 commit into
python:3.8from
miss-islington:backport-0755945-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 14, 2019 •

Copy link
Copy Markdown
Contributor

Join the thread to prevent leaking a running thread and leaking a
reference.

Cleanup also the test:

  • asyncioWindowsProactorEventLoopPolicy became the default policy,
    there is no need to set it manually.
  • Only start the thread once the loop is running.
  • Use a shorter sleep in the thread (100 ms rather than 1 sec).
  • Use close_loop(loop) rather than loop.close().
  • Use longer variable names.
    (cherry picked from commit 0755945)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37278

Join the thread to prevent leaking a running thread and leaking a
reference.

Cleanup also the test:

* asyncioWindowsProactorEventLoopPolicy became the default policy,
  there is no need to set it manually.
* Only start the thread once the loop is running.
* Use a shorter sleep in the thread (100 ms rather than 1 sec).
* Use close_loop(loop) rather than loop.close().
* Use longer variable names.
(cherry picked from commit 0755945)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

@vstinner

Copy link
Copy Markdown
Member

Hum. AppVeyor job didn't start :-(

@asvetlov asvetlov closed this Jun 14, 2019
@miss-islington
miss-islington deleted the backport-0755945-3.8 branch June 14, 2019 11:32
@asvetlov

Copy link
Copy Markdown
Contributor

Ooops. Sorry, I wanted to close-reopen but the bot just deleted the PR :(

@asvetlov

Copy link
Copy Markdown
Contributor

Recreated #14078

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants