Repository navigation
[3.8] bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074) - #14077
Closed
miss-islington wants to merge 1 commit into
Closed
miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Join the thread to prevent leaking a running thread and leaking a reference. Cleanup also the test: * asyncioWindowsProactorEventLoopPolicy became the default policy, there is no need to set it manually. * Only start the thread once the loop is running. * Use a shorter sleep in the thread (100 ms rather than 1 sec). * Use close_loop(loop) rather than loop.close(). * Use longer variable names. (cherry picked from commit 0755945) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Member
|
Hum. AppVeyor job didn't start :-( |
Contributor
|
Ooops. Sorry, I wanted to close-reopen but the bot just deleted the PR :( |
Contributor
|
Recreated #14078 |
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Join the thread to prevent leaking a running thread and leaking a
reference.
Cleanup also the test:
there is no need to set it manually.
(cherry picked from commit 0755945)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue37278