Skip to content

bpo-37279: Fix asyncio sendfile support when extra data are sent in fallback mode.#14075

Merged
asvetlov merged 2 commits into
python:masterfrom
asvetlov:fix-asyncio-sendfile
Jun 15, 2019
Merged

bpo-37279: Fix asyncio sendfile support when extra data are sent in fallback mode.#14075
asvetlov merged 2 commits into
python:masterfrom
asvetlov:fix-asyncio-sendfile

Conversation

@asvetlov

@asvetlov asvetlov commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

@asvetlov
asvetlov requested a review from 1st1 as a code owner June 14, 2019 10:27
@asvetlov asvetlov changed the title bpo-37279: Fix asyncio sendfile support when extra data are sendt in fallback mode. bpo-37279: Fix asyncio sendfile support when extra data are sent in fallback mode. Jun 14, 2019
@aixtools

Copy link
Copy Markdown
Contributor

Many Thanks!!

AIX (which lacks os.sendfile():

test_asyncio passed in 1 min 25 sec

== Tests result: SUCCESS ==

1 test OK.

@asvetlov
asvetlov merged commit ef21523 into python:master Jun 15, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@asvetlov
asvetlov deleted the fix-asyncio-sendfile branch June 15, 2019 11:05
@bedevere-bot

Copy link
Copy Markdown

GH-14100 is a backport of this pull request to the 3.8 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @asvetlov, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ef2152354f03a165c5e3adb53e2276934fabd50a 3.7

@bedevere-bot

Copy link
Copy Markdown

GH-14103 is a backport of this pull request to the 3.7 branch.

asvetlov added a commit to asvetlov/cpython that referenced this pull request Jun 15, 2019
…t in fallback mode. (pythonGH-14075).

(cherry picked from commit ef21523)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington added a commit that referenced this pull request Jun 15, 2019
…allback mode. (GH-14075)

(cherry picked from commit ef21523)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Jun 15, 2019
…t in fallback mode. (GH-14075). (GH-14103)

(cherry picked from commit ef21523)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants