Skip to content

[3.8] bpo-37210: Fix pure Python pickle when _pickle is unavailable (GH-14016)#14055

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-63ab4ba-3.8
Jun 13, 2019
Merged

[3.8] bpo-37210: Fix pure Python pickle when _pickle is unavailable (GH-14016)#14055
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-63ab4ba-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Allow pure Python implementation of pickle to work
even when the C _pickle module is unavailable.

Fix test_pickle when _pickle is missing: declare PyPicklerHookTests
outside "if has_c_implementation:" block.
(cherry picked from commit 63ab4ba)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37210

…GH-14016)

Allow pure Python implementation of pickle to work
even when the C _pickle module is unavailable.

Fix test_pickle when _pickle is missing: declare PyPicklerHookTests
outside "if has_c_implementation:" block.
(cherry picked from commit 63ab4ba)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit cbda40d into python:3.8 Jun 13, 2019
@miss-islington
miss-islington deleted the backport-63ab4ba-3.8 branch June 13, 2019 12:28
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants