-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-140505: Correct "parameters" to "arguments" in MultiCall doc #140512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be changed in more places.
… module description
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are more:
This method takes one parameter,
Signatures themselves are restricted to the top level parameters expected by a
method. For instance if a method expects one array of structs as a parameter,
And most likely:
a client can call methods with parameters
Method has parameters, but it expects and takes arguments.
done. thank you |
|
In June, the editorial board recommended not to make similar changes: |
So, what should we do? Close this PR and corresponding issue? |
|
Even if we consider the terms "argument" and "parameter" interchangeable (I think this would be a great mistake), this PR contains other improvements. And if "argument" and "parameter" are the same, it will not harm to change one to other, isn't? |
How about just make those improvements? |
|
Is it correct that we have closed the issue without merging or closing this PR? |

📚 Documentation preview 📚: https://cpython-previews--140512.org.readthedocs.build/en/140512/library/xmlrpc.client.html#multicall-objects