Skip to content

Conversation

@7576457
Copy link

@7576457 7576457 commented Oct 23, 2025

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 23, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed in more places.

@7576457
Copy link
Author

7576457 commented Oct 23, 2025

I think this should be changed in more places.

Yes, you’re right -- I found one more place where the term should be updated. Everything else seems fine
изображение

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more:

This method takes one parameter,

Signatures themselves are restricted to the top level parameters expected by a
method. For instance if a method expects one array of structs as a parameter,

And most likely:

a client can call methods with parameters

Method has parameters, but it expects and takes arguments.

@7576457
Copy link
Author

7576457 commented Oct 25, 2025

I think there are more:

This method takes one parameter,

Signatures themselves are restricted to the top level parameters expected by a
method. For instance if a method expects one array of structs as a parameter,

And most likely:

a client can call methods with parameters

Method has parameters, but it expects and takes arguments.

done. thank you

@serhiy-storchaka serhiy-storchaka requested a review from a team October 27, 2025 16:57
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025
@hugovk
Copy link
Member

hugovk commented Oct 28, 2025

In June, the editorial board recommended not to make similar changes:

#135160 (comment)

@efimov-mikhail
Copy link
Member

In June, the editorial board recommended not to make similar changes:

#135160 (comment)

So, what should we do? Close this PR and corresponding issue?

@serhiy-storchaka
Copy link
Member

Even if we consider the terms "argument" and "parameter" interchangeable (I think this would be a great mistake), this PR contains other improvements. And if "argument" and "parameter" are the same, it will not harm to change one to other, isn't?

@hugovk
Copy link
Member

hugovk commented Nov 19, 2025

... this PR contains other improvements.

How about just make those improvements?

@efimov-mikhail
Copy link
Member

Is it correct that we have closed the issue without merging or closing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants