Skip to content

gh-139707: Specify winreg, msvcrt and winsound module availability in docs #140429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 2 commits into from
Nov 10, 2025
Merged

gh-139707: Specify winreg, msvcrt and winsound module availability in docs #140429

encukou merged 2 commits into from
Nov 10, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 21, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Oct 21, 2025
@StanFromIreland StanFromIreland changed the title Specify winreg availability in docs Specify winreg module availability in docs Oct 21, 2025
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Oct 21, 2025

There are a few more cases, I will add them to this PR.

@StanFromIreland StanFromIreland marked this pull request as draft October 21, 2025 16:10
@StanFromIreland StanFromIreland marked this pull request as ready for review October 21, 2025 16:13
@StanFromIreland StanFromIreland changed the title Specify winreg module availability in docs Specify winreg, msvcrt and winsound module availability in docs Oct 21, 2025
@StanFromIreland StanFromIreland changed the title Specify winreg, msvcrt and winsound module availability in docs gh-139707: Specify winreg, msvcrt and winsound module availability in docs Oct 21, 2025
@encukou
Copy link
Member

encukou commented Nov 7, 2025

Hmm, I see these all have :platform: Windows in the header. That's a standard Sphinx option but that seems to have no effect since Sphinx 1.1.
Should we remove that or keep it maintained (everywhere)?

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Nov 7, 2025

Should we remove that or keep it maintained (everywhere)?

In my opinion, keeping the existing ones doesn’t have any significant impact, on the other hand, removing them is the same. I don't see any reason to add more. As such, I'm 0 on changing anything with them, although I don't mind removing them all (for consistency, it makes little sense to remove just the three) in this PR either, if you so wish.

@encukou
Copy link
Member

encukou commented Nov 10, 2025

I guess that if we do remove them, it should be its own PR.

@encukou encukou merged commit 13fa313 into python:main Nov 10, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 10, 2025
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 10, 2025

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 10, 2025

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
672471e 
…ilability in docs (pythonGH-140429)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141350 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
7cb6cf5 
…ilability in docs (pythonGH-140429)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141351 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
encukou pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.14] gh-139707: Specify winreg, msvcrt and winsound module av…
63a3737 
…ailability in docs (GH-140429) (GH-141351)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.13] gh-139707: Specify winreg, msvcrt and winsound module av…
1f9f8e5 
…ailability in docs (GH-140429) (GH-141350)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@encukou encukou mentioned this pull request Nov 11, 2025
Closed
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
5a5b0c6 
…ilability in docs (pythonGH-140429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes

@encukou encukou Awaiting requested review from encukou

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @encukou @aisk