gh-140421: Fix perf trampoline on older macOS #140422
Closed
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use mach_absolute_time() when clock_gettime() is not available. * Define MAP_ANONYMOUS to MAP_ANON if the latter is defined and the former is not. This matches what is done elsewhere in the code base in this situation, e.g. mmapmodule.c. * Don't build perf trampoline on ppc systems, where getting this to work would be a lot more effort.
jmroot
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
Member
|
Closing, see #140421 (comment). |
6 tasks
|
@hugovk A lack of support from Apple doesn’t really mean that open-source projects should pro-actively sabotage the code which could otherwise work perfectly fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mach_absolute_time() whenclock_gettime()is not available.MAP_ANONYMOUStoMAP_ANONif the latter is defined and the former is not. This matches what is done elsewhere in the code base in this situation, e.g.mmapmodule.c.