gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL
#140288
Conversation
|
Please merge #140298 first. |
johnslavik
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
| # Isolated mode implies -E, -P and -s, purifies sys.path and ignores PYTHON* | ||
| # variables. | ||
| if isolated: | ||
| cmd_line.append('-I') |
There was a problem hiding this comment.
To reuse this routine and spawn_asyncio_repl below, we need to have a knob to not pass -I since that ignores PYTHONSTARTUP completely.
The asyncio REPL currently doesn't comply to that, which is a separate issue I'll report having learnt this.
| def test_asyncio_repl_reaches_python_startup_script(self): | ||
| with os_helper.temp_dir() as tmpdir: | ||
| script = os.path.join(tmpdir, "pythonstartup.py") | ||
| with open(script, "w") as f: | ||
| f.write("print('pythonstartup done!')" + os.linesep) | ||
| f.write("exit(0)" + os.linesep) | ||
|
|
||
| env = os.environ.copy() | ||
| env["PYTHON_HISTORY"] = os.path.join(tmpdir, ".asyncio_history") | ||
| env["PYTHONSTARTUP"] = script | ||
| subprocess.check_call( | ||
| [sys.executable, "-m", "asyncio"], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, | ||
| env=env, | ||
| timeout=SHORT_TIMEOUT, | ||
| ) |
There was a problem hiding this comment.
Covered by TestPythonStartup now, so not needed here.
|
This is ready, but Windows doesn't pass because of GH-141262. |
|
It seems that these unclosed loop warnings regressed (stopped appearing) in the recent releases -- this is bad, but we can fix them separately and we can also fix the asyncio REPL in this regard by actually closing the loop (in a separate PR). In the meantime, updating this branch should make the CI green. |
|
Looks like I was confused about the regression -- that's good news! This will have to wait until the loop is properly closed in the asyncio REPL. |
It does! Cool! |
This reverts commit 875fd2a.
| except SystemExit: | ||
| raise |
There was a problem hiding this comment.
This is also why I didn't add a test for this.
|
I'll see if I can simplify this. I think the tests are slightly overcomplicated. |
johnslavik
left a comment
johnslavik
left a comment
There was a problem hiding this comment.
I'll come back to this after completing GH-140648.
1 participant
This is generally a work in progress; tests are needed.
The asyncio patch is simple and ready.
PYTHONSTARTUPexceptions #140287