bpo-37252: Fix devpoll tests#14017
Merged
Merged
Conversation
Contributor
|
Would you point on commits that produced test failures? |
Contributor
Author
Contributor
|
We don't have a Solaris buildbot any more, so we'll have to take your word for it. |
Contributor
|
Thanks @kulikjak for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
(cherry picked from commit 95da826) Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
|
GH-15948 is a backport of this pull request to the 3.8 branch. |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_devpoll currently ends with two failures with Python 3.8 on Solaris.
First one is wrong number of arguments to devpoll.register function (which thrown the same error as expected in 3.7 but now acts differently).
Second one is that register and modify no longer throw OverflowError when negative number is given as second argument, but rather a ValueError. I am not sure whether this is just a small semantics change or some bigger problem (documentation doesn't mention what error should be thrown).
So I fixed it by changing the expected thrown error but there might be other problem as well.
https://bugs.python.org/issue37252