GH-139596: Cease caching config.cache & ccache in GH Actions #139623
Conversation
AA-Turner
changed the title
|
For future reference:
|
| with: | ||
| path: config.cache | ||
| # Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python | ||
| key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ needs.build-context.outputs.config-hash }}-${{ env.pythonLocation }} |
There was a problem hiding this comment.
Can we also remove config-hash from reusable-context.yml?
There was a problem hiding this comment.
Yes, and the config_hash input for some other reusables. Will open a followup.
gpshead
added
needs backport to 3.13
|
Thanks @AA-Turner for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @AA-Turner and @gpshead, I could not cleanly backport this to |
|
Sorry, @AA-Turner and @gpshead, I could not cleanly backport this to |
|
the backport labels were opportunistic checks - actions configs have been rearranged since |
…ions Manual redo/backport of python#139623 to 3.14.
| path: ${{ env.CROSS_BUILD_WASI }}/config.cache | ||
| # Should be kept in sync with the other config.cache step above. | ||
| key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ env.WASI_SDK_VERSION }}-${{ env.WASMTIME_VERSION }}-${{ inputs.config_hash }}-${{ hashFiles('Tools/wasm/wasi/__main__.py') }}-${{ env.pythonLocation }} | ||
| run: python3 Tools/wasm/wasi.py make-build-python |
There was a problem hiding this comment.
Looks like a merge misfire:
| run: python3 Tools/wasm/wasi.py make-build-python | |
| run: python3 Tools/wasm/wasi make-build-python |
There was a problem hiding this comment.
Yep, will include this in the followup too.
|
Followup: #141451 |
hugovk
removed
needs backport to 3.13
…ythonGH-139623) * Cease caching config.cache in GH Actions\ * Remove ccache action
5 participants
This removes the
config.cacheandccachecaches from GitHub Actions. Note that we still install and useccacheviaposix-deps-apt.sh, so we will get the benefit from that still (if any), but we will no longer save it to the GHA cache.A