Skip to content

bpo-37216: Fix filename in mac using document#13962

Closed
MakDon wants to merge 1 commit intopython:masterfrom
MakDon:fix-issue-37216-filename
Closed

bpo-37216: Fix filename in mac using document#13962
MakDon wants to merge 1 commit intopython:masterfrom
MakDon:fix-issue-37216-filename

Conversation

@MakDon
Copy link
Copy Markdown
Contributor

@MakDon MakDon commented Jun 11, 2019

The python folder name is wrong in mac using document.

$ ls /Applications | grep Python
Python 2.7
Python 3.5
Python 3.6
Python 3.7

And my system version is macOS Mojave Version 10.14.5(18F132)
$uname -v
Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64

This commit should be backport to 2.7, 3.5, 3.6.
DO NOT backport to 3.7 and 3.8 because i create another PR to fix the filename and version in branch 3.7 and 3.8.
See:
#13963 for 3.7,
#13964 for 3.8
#13966 for 3.9

https://bugs.python.org/issue37216

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 11, 2019
@MakDon MakDon changed the title bpo-37216: Fix filename in mac using document [WIP] bpo-37216: Fix filename in mac using document Jun 11, 2019
@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 11, 2019

I could not find Build Applet mentioned on distributing-python-applications-on-the-mac. It seems that is has been removed.

@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 11, 2019

The document of Build Applet on Using Python on a Macintosh should be another issue. I will create a new issue for it if i could find something about it.

@MakDon MakDon changed the title [WIP] bpo-37216: Fix filename in mac using document bpo-37216: Fix filename in mac using document Jun 11, 2019
@ned-deily
Copy link
Copy Markdown
Member

@MakDon, thanks for the PRs and for noticing the spurious reference to Build Applet, a tool that was removed in Python 3. The whole "Using Python on a Macintosh" chapter has not been updated in a long time and is woefully out-of-date. Despite good intentions, I have not yet gotten around to doing it but I will do so shortly - really. I'm going to push the PRs you have already made but I would ask you to hold off on making further changes as major rewrites are necessary. Thanks!

@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 11, 2019

I have made the requested changes; please review again.
Thanks bot :D

@bedevere-bot
Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@ned-deily
Copy link
Copy Markdown
Member

It looks like your newer PR, #13966, effectively replaces this PR so I"m just going to close this one and merge the other. Thanks!

@ned-deily ned-deily closed this Jun 13, 2019
@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 13, 2019

@ned-deily hummm, the problem is, the folder name in 2.7, 3.5, 3.6 is wrong so i create this pr for the folder name.

@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 13, 2019

But it seems that it would be conflict if backport directly. Is it the best way is create PR for each version?

@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 13, 2019

For

I would ask you to hold off on making further changes as major rewrites are necessary.

i would not create new PR the the floder name issue. Thanks for your review! :D

@ned-deily
Copy link
Copy Markdown
Member

But it seems that it would be conflict if backport directly. Is it the best way is create PR for each version?

The change in this case is a bit unusual in that the changed lines include the version number in them so an automated backport is not possible and someone, either the PR submitter or the core developer merging the original PR, would need to manually create the backports. In general, it's best to just produce the PR for the master branch and then once it has been reviewed and accepted then produce any needed backport PRs if the core developer hasn't already done so.

@MakDon
Copy link
Copy Markdown
Contributor Author

MakDon commented Jun 13, 2019

But it seems that it would be conflict if backport directly. Is it the best way is create PR for each version?

The change in this case is a bit unusual in that the changed lines include the version number in them so an automated backport is not possible and someone, either the PR submitter or the core developer merging the original PR, would need to manually create the backports. In general, it's best to just produce the PR for the master branch and then once it has been reviewed and accepted then produce any needed backport PRs if the core developer hasn't already done so.

Thanks for your description. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants